gh-89640: Restore configure error message on failure to detect float word order#126569
Merged
erlend-aasland merged 2 commits intopython:mainfrom Nov 8, 2024
Merged
Conversation
…float word order Before python#126387, if we didn't detect float word order we'd raise the following configure error: ``` Unknown float word ordering. You need to manually preset ax_cv_c_float_words_bigendian=no (or yes) according to your system. ``` This puts it back (except for host_cpu arm or wasm).
hoodmane
force-pushed
the
unknown-float-order-error
branch
from
8d5b726 to
f3c6d7c
Compare
erlend-aasland
approved these changes
Nov 8, 2024
Contributor
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
Thanks! (I'll make some style adjustments before landing)
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…float word order (python#126569) Before python#126387, if we didn't detect float word order we'd raise the following configure error: Unknown float word ordering. You need to manually preset ax_cv_c_float_words_bigendian=no (or yes) according to your system. This puts it back (except for ARM or WASM, which as hardcoded).
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…float word order (python#126569) Before python#126387, if we didn't detect float word order we'd raise the following configure error: Unknown float word ordering. You need to manually preset ax_cv_c_float_words_bigendian=no (or yes) according to your system. This puts it back (except for ARM or WASM, which as hardcoded).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before #126387, if we didn't detect float word order we'd raise the following configure error:
This puts it back (except for host_cpu arm or wasm).
cc @erlend-aasland